ICRAR / crc32c

A python package implementing the crc32c algorithm in hardware and software
GNU Lesser General Public License v2.1
41 stars 25 forks source link

Mac wheels for 1.7 #9

Closed kislyuk closed 5 years ago

kislyuk commented 5 years ago

Thanks again for this great package. I just wanted to point out that pre-built wheels (which are immensely useful) are missing for Mac OS in the latest released version, 1.7. Hopefully they can be added.

rtobar commented 5 years ago

Hi Andrey,

Thanks for pointing that out, I have just created and added them. Could you give them a try, and hopefully mark this as resolved if everything is fine?

Just to clarify, even though you added a MacOS build in our Travis CI, I'm still generating the MacOS wheels myself under a more controlled environment to ensure maximum portability across MacOS versions. They basically should be usable under any MacOS 10.6+ version. I do that by using the official MacOS packages instead of using homebrew's or mac port's versions of python, which would yield wheels that are not as portable.

rtobar commented 5 years ago

Closing as the wheels seem to be fine.