search

ICRAR / daliuge

The DALiuGE Execution Engine
GNU Lesser General Public License v2.1
24 stars 7 forks source link

Liu 338 #220

Closed awicenec closed 1 year ago

awicenec commented 1 year ago

Pull request covers mainly the new treatment of the filepath and removal of the dirname component parameters. filepath is now covering both, by slightly changing the interpretation. That also required changing a number of the test graphs. In fact the update also made the treatment of check_file_path_exists more consistent, since it is now really required to set it to false if it does not exist, which is the case for most of the files generated during a workflow run.

In addition also an import bug in pyfunc.py has been fixed and the setting of the sleepTime when translating in test mode has also been fixed.

The many changes in xml2palette.py are automatic code formatting changes and can be ignored, also because the xml2palette.py tool is now deprecated and will be removed soon.

coveralls commented 1 year ago

Coverage Status

Coverage: 81.896% (+0.04%) from 81.859% when pulling 63faed7fb9cc1a7d6833946291cbbeb12bafd591 on liu-338 into 5bf5a474a2e87db89a2a29b0983ce03ace7006e2 on master.

awicenec commented 1 year ago

Thanks for the comments, have integrated those changes as well as merged with the validate-graphs PR.