ICRAR / daliuge

The DALiuGE Execution Engine
GNU Lesser General Public License v2.1
24 stars 7 forks source link

Liu 367 #235

Closed awicenec closed 7 months ago

awicenec commented 1 year ago

Thus PR covers the full application of named ports for application components, rather than just Pyfunc components. It is now possible to connect any component with a port having the same name as one of the application arguments or component parameters and the engine will connect the value with the input or output. The component will still need to read or write. The best example is the updated version of dlg.apps.simple.SleepApp. There is now also a test related to that, based on a new example graph. In addition also the HelloWorld_Universe graph has been updated to run without the addition of the example components and has also been added to the tests, because there was no test for the gather component at all and the gather component broke with the first version of this update. We now have a few simple functions in dlg.apps.simple_functions, which are mostly used for testing, but are also useful to show how things are being done when using functions. An InputFiredAppDROP will now first run it's internal _run() method and then execute the run() method provided by the App component implementation. The checking and population of the named ports is in that _run() method and thus applies to any component derived from the BarrierAppDROP(InputFiredAppDROP).

coveralls commented 1 year ago

Coverage Status

coverage: 79.862% (-0.6%) from 80.505% when pulling ba777705e3dcf6727197fc3af1a2b0bda9ebff4c on liu-367 into 7a54b4942125da3f30889c11de5e15db04fb1897 on master.