ICRAR / daliuge

The DALiuGE Execution Engine
GNU Lesser General Public License v2.1
24 stars 7 forks source link

LIU-385: Add support for SubGraphs in translator #262

Closed myxie closed 5 months ago

myxie commented 5 months ago

This supports SubGraphs with no InputApps, which functionally ignores the entire SubGraph construct.

Logical Graph Translated Graph
image image

This does not address the functionality of sub-graphs with input apps, nor does it make any attempt to address the translation of those graphs; this may lead to undefined behaviour if a sub-graph with input apps is submitted for translation.

Summary by Sourcery

This pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. It introduces a new property to identify SubGraph nodes and updates relevant functions to process these constructs.

sourcery-ai[bot] commented 5 months ago

Reviewer's Guide by Sourcery

This pull request adds support for SubGraphs in the translator, specifically handling SubGraphs with no InputApps. The changes ensure that SubGraphs are recognized and processed correctly, while ignoring the entire SubGraph construct if it has no InputApps. This update does not address the functionality of SubGraphs with InputApps, which may lead to undefined behavior if such SubGraphs are submitted for translation.

File-Level Changes

Files Changes
daliuge-translator/dlg/dropmake/lg.py
daliuge-translator/dlg/dropmake/dm_utils.py
daliuge-translator/dlg/dropmake/lg_node.py
daliuge-translator/dlg/dropmake/definition_classes.py
Added support for SubGraphs in the translator, including recognition and processing of SubGraphs with no InputApps.
coveralls commented 5 months ago

Coverage Status

coverage: 79.626% (-0.03%) from 79.653% when pulling caa24e35237b49512445bfedebf8d67ae21a53c9 on LIU-385 into 22fb53d092c540c4af90c4fce45c929d2ed8e95a on master.