ICRAR / daliuge

The DALiuGE Execution Engine
GNU Lesser General Public License v2.1
24 stars 7 forks source link

LIU-390: Remove Plasma and PyArrow #269

Closed myxie closed 4 months ago

myxie commented 4 months ago

Issue

We want to deprecate/remove Plasma and PyArrow as they are preventing us from running DALiuGE in Python 3.11+; see LIU-390 for more details.

Solution

I have removed all reference to Plasma and PyArrow from the repository, and added that code to the external daliuge-plasma-components repository.

Summary by Sourcery

Removed support for Plasma and PyArrow, including related classes, imports, and tests.

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request removes all references to Plasma and PyArrow from the daliuge-engine codebase. This includes the deletion of the PlasmaIO and PlasmaFlightIO classes, removal of related imports, and the deletion of test cases and utility functions that relied on PlasmaDROP and PlasmaFlightDROP. Additionally, the plasmaflight.py and plasma.py files have been deleted.

File-Level Changes

Files Changes
daliuge-engine/dlg/data/io.py
daliuge-engine/dlg/data/drops/__init__.py
daliuge-engine/dlg/graph_loader.py
daliuge-engine/dlg/apps/plasmaflight.py
daliuge-engine/dlg/data/drops/plasma.py
Removed all references to Plasma and PlasmaFlight from the data IO and drop management modules.
daliuge-engine/test/test_drop.py
daliuge-engine/test/test_droputils.py
Removed all test cases related to PlasmaDROP and PlasmaFlightDROP.

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
coveralls commented 4 months ago

Coverage Status

coverage: 79.478% (+0.009%) from 79.469% when pulling cc2a7d80b8d4bc4bff53780460311257595cbee6 on LIU390-RemovePlasmaAndPyArrow into db91b75d352d9f90b45eebdda1de8a2d346d4a58 on master.

myxie commented 4 months ago

@awicenec if you're happy with this I will merge it :)