LIU-396: Add additional port options to CLI for NodeManager.

ICRAR / daliuge

The DALiuGE Execution Engine

GNU Lesser General Public License v2.1

24 stars 7 forks source link

LIU-396: Add additional port options to CLI for NodeManager. #277

Closed myxie closed 1 month ago

myxie commented 1 month ago

Can now specify --rpc_port and --event_port.
Verified this works and two NodeManagers can be run using localhost.

coveralls commented 1 month ago

coverage: 79.69% (-0.03%) from 79.722% when pulling f9a013f41c7f94868e1a921599b5ef428c8238ec on LIU-396 into 10110dac42b9378b10073a210c2353f550d006d0 on master.

awicenec commented 1 month ago

I've merged this with the pyfunc_code branch and will then merge into master.

myxie commented 1 month ago

@awicenec this wasn't complete, which is why it was in a draft state and the description was incomplete. I am still in the process of working on the unit-tests which are to be applied to this branch/set of changes.

I think in the future, there is value in keeping each individual branch's merge into main/master separate, as it means a revert of changes in the event there is a breaking change does not undo all branches. It also reduces the likelihood of merging incomplete work, as in this case.

myxie commented 1 month ago

If you prefer the idea of merging multiple branches all at once into one branch and delivering that change, may I recommend the following?

If the current state of the branches are:

liu-XXX->master, PR 89
alt_featureX->master, PR 92
liu-XXY->master, PR 93

Create another branch off master with the intended version number, e.g. v.4.X.0, and then change the targets of each PR to that branch, merge each branch into that branch, and then merge the version branch into main.