search

ICRAR / leap-accelerate

Low-frequency Excision of the Atmosphere in Parallel
GNU General Public License v2.0
1 stars 1 forks source link

CMake build improvements #22

Closed rtobar closed 4 years ago

rtobar commented 4 years ago

These are minor improvements to the cmake functionality. They allow to use casacore installations in non-standard locations, and state the CUDA dependency as a required one, better reflecting the current state of the code.

rtobar commented 4 years ago

At the end I ended up fixing FindCasacore.cmake to properly handle the REQUIRED keyword (it was only a difference in variable name casing).

Would you want me to do the merge to the master, or you'd rather do it?

calgray commented 4 years ago

Usually I'd always let the creator hit the merge in case there are still minor commits after the review, sanity testing or the target branch needs to change.

Good find on the casing, happy for you to merge after a green build.