Review Issue 4: BalanceSheetInputsCollection.js

[ehsuGit]

Please review the BalanceSheetInputsCollection.js, linked here

Use these guidelines:

• Architecture
• Design
• JS
• React

DUE: 10/7

[Ssunoo2]

Duplicated code: the list is duplicated many times. You can create a common list of the fields and then refer to them in your functions Dry principles: define and dumpOne both have repeated fields

[bobbyir]

Files names should use camel case

[skulibas]

• Design-01: The define and dumpOne methods have similar patterns in terms of handling document properties.
• Design-05: the comment on define could be simplified
• Design-07: long lists of parameters in the define method

[daomcgill]

Refactor handling of the long list of parameters. It is used multiple times.

[bfd2]

• define and dumpOne have similar parameters
• Have a common list of fields for that long list of parameters.

[ehsuGit]

Architecture 02 - File name is BalanceSheetInputsCollection, folder is named BalanceSheetInput and other file is BalanceSheetInputSchema. Change file name to BalanceSheetInputCollection Design 01/08 - The huge blocks of input data could be stored somewhere else, duplicated 4 times in the code 09 - Duplicated code could be moved somewhere else for reuse JS and ESLint OK React OK

[lukepag]

File name can be changed to keep consistency Duplicate code that also seems a bit too long to use as a parameter