ICS-414-In5PIRE / in5PIRE-code

MIT License
0 stars 1 forks source link

Review Issue: BalanceSheetInputsCollection.js #128

Open ehsuGit opened 2 days ago

ehsuGit commented 2 days ago

Please review the BalanceSheetInputsCollection.js, linked here

Use these guidelines:

DUE: 10/7

Ssunoo2 commented 5 hours ago

Duplicated code: the list is duplicated many times. You can create a common list of the fields and then refer to them in your functions Dry principles: define and dumpOne both have repeated fields

bobbyir commented 5 hours ago

Files names should use camel case

skulibas commented 5 hours ago
daomcgill commented 5 hours ago

Refactor handling of the long list of parameters. It is used multiple times.

bfd2 commented 4 hours ago
ehsuGit commented 2 hours ago

Architecture 02 - File name is BalanceSheetInputsCollection, folder is named BalanceSheetInput and other file is BalanceSheetInputSchema. Change file name to BalanceSheetInputCollection Design 01/08 - The huge blocks of input data could be stored somewhere else, duplicated 4 times in the code 09 - Duplicated code could be moved somewhere else for reuse JS and ESLint OK React OK