search

ICSM / ampere

A tool to fit the SED and spectra of dusty objects to constrain, among other things, the dust properties and mineralogy
6 stars 2 forks source link

Implement priors #9

Closed pscicluna closed 3 years ago

pscicluna commented 6 years ago

Implement a range of generic priors for all models (e.g. flat, flat within some bounds, etc). Not all possible optimisers will be able to understand this, so it may additional code in optimiser objects to maintain uniformity.

pscicluna commented 6 years ago

Simple uniform priors with bounds have been added to the existing models. I think this is good enough to remove it from the v0.1 milestone, but the issue should remain open so we don't forget to add more.

pscicluna commented 3 years ago

Adding many default priors seems like an unnecessary amount of work. We should instead give a clear demonstration of how users can pass their own function in place of the built in one by writing their own prior as a new_function() in their script and then setting model.prior = new_function. Unless anyone objects I will close this.