search

ICSM / pgmuvi

Python gaussian processes for inference on multi-wavelength light curves
https://pgmuvi.readthedocs.io
GNU General Public License v3.0
12 stars 6 forks source link

The name gps conflicts with existing package #1

Closed sundarjhu closed 12 months ago

sundarjhu commented 2 years ago

Please rename gps.py to GPS.py or something else. There's an existing package called gps (https://pypi.org/project/gps/), and the command to import SpectralMixtureGPModel throws an ImportError.

Although it would be possible to add an extra path command and prepend the path to gps.py to the existing path, renaming the file requires less effort.

pscicluna commented 2 years ago

This should be solved by moving test_script.py up a directory, so the import becomes from pgmuvi import gps to resolve the ambiguity.

pscicluna commented 1 year ago

When using this as a package, the import will become from pgmuvi.gps import ... so I'm going to ignore the error and move test_script up a directory, forcing the future-proof import, instead.

From: Sundar Srinivasan @.> Sent: Friday, June 24, 2022 8:05:38 PM To: ICSM/pgmuvi @.> Cc: Subscribed @.***> Subject: [ICSM/pgmuvi] The name gps conflicts with existing package (Issue #1)

Please rename gps.py to GPS.py or something else. There's an existing package called gps (https://pypi.org/project/gps/), and the command to import SpectralMixtureGPModel throws an ImportError.

Although it would be possible to add an extra path command and prepend the path to gps.py to the existing path, renaming the file requires less effort.

— Reply to this email directly, view it on GitHubhttps://github.com/ICSM/pgmuvi/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAD4J6QXFHBKT7XNYVCT4D3VQX2HFANCNFSM5ZYSX7YQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

pscicluna commented 12 months ago

Now that test_script is deprecated and the new API is in place, this issue should have been closed a while ago.