search

ICSM / pgmuvi

Python gaussian processes for inference on multi-wavelength light curves
https://pgmuvi.readthedocs.io
GNU General Public License v3.0
12 stars 6 forks source link

[Feature Request] summary of results written to file #27

Open sundarjhu opened 11 months ago

sundarjhu commented 11 months ago

For further analysis, I would like PGMUVI to return the following information in an output file: the period, the mean magnitude, the loss, and the best-fit model (magnitude as a function of time)

The name of the output file should be provided by the user; if not, default to results.

A VOTable format with one column each for the period, the mean magnitude, the loss, any other model parameters, and the best-fit model (which can be a numpy array of model magnitudes for each time coordinate provided by the user).

pscicluna commented 11 months ago

I just pushed an initial implementation in ab2b6e76e4ce9f18f55e07ba9174fd98bceee58d. Please try it out and see if it is close enough to start with.

sundarjhu commented 10 months ago

Forgot to respond to this. [https://github.com/ICSM/pgmuvi/pull/41] (The PR I initiated) has updated the code to add a to_table method which returns an astropy table, and the write_votable method you created now just calls to_table and writes the result to file.

A much more recent update to to_table (47bc847f0f8dcced57283156e79a78d82a8c7822), which I haven't tested yet, uses squeeze() to remove all the superfluous dimensions from the tensors before appending them as table columns.