ICSM / pgmuvi

Python gaussian processes for inference on multi-wavelength light curves
https://pgmuvi.readthedocs.io
GNU General Public License v3.0
12 stars 6 forks source link

[BUG] `set_constraint` method in `lightcurve.py` not suitable for 2-component `mixture_means` #37

Open sundarjhu opened 10 months ago

sundarjhu commented 10 months ago

Describe the bug The code in set_constraint is currently applicable to 1-component fits only. For constraints to both elements in mixture_means for a 2-component fit, it breaks at line 648 (constraint[key].lower_bound). The code needs to be generalised to multiple components and for all applicable parameters, including mixture_means.

Also, set_hypers refers to it as sci_kernel.mixture_means, whereas this reference also produces an error when using it with set_constraints, which seems to prefer mixture_means.