search

ICT4Dat / ict4dat-news-android

ICT4D.at's App to combine all ICT4D news into one Android application
Apache License 2.0
5 stars 1 forks source link

Feat/219 reimplement about page #225

Open jobguitiche opened 6 months ago

jobguitiche commented 6 months ago

fixes #219

spipau commented 6 months ago

@jobguitiche I merged my other branch into develop and now into yours. There was only one conflict and looks good :+1:

I also fixed the ktlint issues in the MoreFragment but did not touch any other files as you are currently working on them. Please run ktlint from time to time to see if our code has standard formatting.

spipau commented 2 weeks ago

@jobguitiche Long time no hear! I just updated my computer to the latest version of Ubuntu and wanted to test my Android setup. So I checked out our project and realized that we never merged this Pull Request! So I started to fix my comments and improve a bit the rest of the code. Could you please review again and let me know if you agree with my changes? If we merge this then I'd say that we should update all dependencies in a new PR and then release a new version :+1:

Hope you are doing good! :slightly_smiling_face: