ICTO / ansible-jenkins

Ansible playbook: Jenkins
MIT License
282 stars 172 forks source link

Added ability to configure jenkins port and prefix #16

Closed sumdog closed 9 years ago

sumdog commented 10 years ago

This should solve Issue #13 as well as provide a basis for other configuration options. I used lineinfile because I could the ini_file task to work (tried using a section='', but that didn't adjust the option). This way is a little better in it preserves all the other config file comments.

Also added e-mail configuration template

kpx-dev commented 9 years ago

hi @sumdog Thanks for the PR! This would help us consume this Jenkins role easier. One feedback though, I think the recommended way is to put var in the vars dir (https://github.com/ICTO/ansible-jenkins/blob/development/vars/main.yml). So I'm thinking you should define a default there and consume playbook can overwrite that var? What do you think?

@tberton can you help CR this PR please?

Thanks!