search

ICTU / zap2docker-auth-weekly

Zap baseline scanner in Docker with authentication
Apache License 2.0
104 stars 72 forks source link

Consider submiting a PR to zaproxy #5

Closed psiinon closed 5 years ago

psiinon commented 6 years ago

Is the authentication working well for you? If so how about submitting a PR back to https://github.com/zaproxy/zaproxy ? That way your work will help more people and you wont have to keep applying your changes every time we update our scripts.

0xRCE commented 6 years ago

Hi Simon,

Yes, the authentication works fine for us. I will cleanup this repo and make a PR to the zaproxy repo in the coming weeks.

tumluliu commented 6 years ago

HI @remoteadmin , may I ask if you are still preparing for submitting a PR to zaproxy? I am asking because we are so requiring this great auth options feature of your custom scripts. If the PR is gonna happen soon, we may wait and deploy the next version of zaproxy with auth. Otherwise, we will switch from zaproxy to here. Thanks!

0xRCE commented 6 years ago

Hi Simon,

We did some cleanup and refactoring to use the new hook mechanism. You can see the result in this feature branch. If you are satisfied with the solution we are happy to do a PR.

Please let us know.

dhartford commented 5 years ago

Hi Team, Would it be possible to attempt another engagement on this? As an end-user trying to find a means for more automated (CLI) zap usage w/ authentication, I like the methods proposed here.

Reviewing https://github.com/zaproxy/zaproxy/issues/4105 and the PR's associated with it and their current delayed/blocked state for several months (associated with a GSOC which may have ended), I would like to see the great work done here pulled into zaproxy.

fniessink commented 5 years ago

I'll discuss with @dicksnel next week and see what we can do.

dicksnel commented 5 years ago

The new hook mechanism of zap-baseline.py from OWASP will be used, so a PR is no longer needed.