ICTatRTI / coconut-analytics

Browserified & backboned version of coconut-reports
Other
2 stars 3 forks source link

Analysis Report showing incorrect cases completed at household level #316

Open scloo opened 6 years ago

scloo commented 6 years ago

Humphrey reported: "I have ran monthly report for November, 2017 (125 cases) and it appears that the analysis report [Screenshot B] does not account for the cases completed at household level (24 cases) [Screenshot A] i.e. case ids 116743; 116703; 116688; 116666; 116667 etc have been completely followed up to the household level but do not reflect in to the analysis report[Screenshot B]."

scloo commented 6 years ago

The problem has been traced to the Case key names in the analytics codes that has not been properly updated to Camel Case. After updating them, the Analysis report is showing the proper result for the cases completed at household level. Also in the Case view dialog where there were numerous lines displayed as undefined, these too have been resolved.

scloo commented 6 years ago

Followup Comments from Humphrey: "noted some discrepancy with the number of completed cases in case follow up status reports (Screenshot 1) and analysis report (screenshot 2) i.e. In the case follow-up status report, there are 30 cases completed at the household level while in the analysis report, there are only 4 cases completed at the household level."

scloo commented 6 years ago

The discrepancies are now resolved. IN Case.completeHouseholdVisit() method, the condition test was @.Household?.complete is "true". Changed the string "true" to a boolean value true, as in the case doc, this is a boolean and not string.

gmcressman commented 6 years ago

Why are the total number of cases and the total number of complete households different on these two reports?

screen shot 2018-01-30 at 4 22 25 pm screen shot 2018-01-30 at 4 21 53 pm