search

ICTatRTI / coconut-analytics

Browserified & backboned version of coconut-reports
Other
2 stars 3 forks source link

Compare weekly facilities report displaying null values #324

Open scloo opened 6 years ago

scloo commented 6 years ago

The report shows null values in the Zone and District columns, when selecting the Facility filter. screen1.png

scloo commented 6 years ago

Also there was a whole bunch of console errors about "Can't find facility xxxxxx" as shown in screenshot below: (These only occur for Zanzibar data but not on democs) screen2.png

scloo commented 6 years ago

There seem to be a inconsistent usage of the FacilityHierarchy class. Supposed to switch to GeoHierarchy class which combines FacilityHierarchy methods. However in different places, it was calling the FacilityHierarchy methods. Fixed the codes to use methods in the GeoHierarchy class and no longer showing the null values.

However there is still a performance issue. When we switch the filter attributes, example, switching from District to Facility before the processing ends, it will still continue to process for District and then proceed to process Facility. Hence it takes a bit longer than desired to get the result for Facility in this case. Suspect that it is due to using Promises which is asynchronous.

gmcressman commented 6 years ago

Well, it's better, but why am I seeing "2016q4" for a 2017 time period? There are certainly other odd values on this report.

screen shot 2018-01-30 at 4 43 50 pm

gmcressman commented 6 years ago

There are many empty columns on the right of this report. It still doesn't look right to me.