IDAES / examples-pse

(ARCHIVED - use IDAES/examples) Example Python code, Jupyter Notebooks, and other files for the IDAES PSE
https://idaes.github.io/examples-pse/
Other
20 stars 36 forks source link

NGCC + SOEC Assert Solution #160

Closed eslickj closed 1 year ago

eslickj commented 2 years ago

This adds a few asserts to the NGCC + SOEC notebook to make sure if something changes in IDAES we know if it affects the solution. This should tell us if the model breaks with the results in our report. I also changed a bunch of variables and constraints to expressions, so that I can deactivate the capital cost constraints and not have to solve the extra constraints. Switching to expressions doesn't really seem to affect the model performance at all, I just don't want to carry unneeded constraints and this was the most straight forward thing I could do without messing things up. Once I do the capital/optimal cost optimization at full load, I can deactivate the capital cost constraints for the turn-down runs.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
bpaul4 commented 2 years ago

FYI, values using CCS accounts will probably change after https://github.com/IDAES/idaes-pse/pull/1030 is merged.

eslickj commented 1 year ago

@andrewlee94 and @bpaul4, I added the missing constraints, but the results may change after https://github.com/IDAES/idaes-pse/pull/1030, so I may need to update the asserts again. I hit auto-merge on that PR, so hopfully we'll find out soon.

ksbeattie commented 1 year ago

@eslickj is this for the Nov (this week) release or the Feb release?

eslickj commented 1 year ago

@ksbeattie it can be for Feb.

eslickj commented 1 year ago

I found another problem. Producing hydrogen lowers the cooling duty in the NGCC + SOEC since it lowers the condenser duty by a lot since steam is extracted from the steam cycle. I need to fix some cooling duty parameters at the NGCC (no SEOC) values to get a cooling system sized for the SOEC to be able to turn off. Working on that now.

eslickj commented 1 year ago

@bpaul4 and @andrewlee94, I'm done with this now. It should be ready for a final review. @andrewlee94 I'll address your comments on the RSOFC model in my next PR. There are some convergence issues with the off-design runs in that model, and I'm going to start in on those next.

eslickj commented 1 year ago

Okay, I addressed comments.