Closed MarcusHolly closed 1 year ago
I'm not quite sure why this warning is appearing because I don't believe I am setting mole fraction bounds anywhere.
@MarcusHolly You probably need to go through the Separator code to find out where that warning is being triggered - my guess is during creation of the outlets but that is just a guess.
Also, you can find icons for most unit operations here: https://github.com/IDAES/idaes-pse/tree/main/idaes/models/unit_models/icons which you should use in these examples. Notably, Separators are traditionally shown as a triangle, not a square.
@andrewlee94 So the issue is that the bounds are being defined in the property package (https://github.com/IDAES/idaes-pse/blob/main/idaes/models/properties/modular_properties/examples/CO2_H2O_Ideal_VLE.py) and then the FTPx modular properties file is just overwriting these bounds. Is there a simple way/line of code that can mute the bounds from being set in the first place so that this warning isn't displayed?
The line setting the bounds on mole fractions should be removed from (https://github.com/IDAES/idaes-pse/blob/main/idaes/models/properties/modular_properties/examples/CO2_H2O_Ideal_VLE.py.
So should I open a new PR for this simple change in the IDAES repo? All of the other prop packs are fine (do not include mole_frac_comp in the state bounds).
@MarcusHolly Yes, please do (and do a quick check of the others whilst you are there).
Not sure how to go about resolving this one failure... the changes made in the last commit were very minimal and everything worked well before that.
@MarcusHolly Looks like the failure was a random one - rerunning the test fixed it.
Proposed changes:
Will add information for the following unit models into jupyter notebook
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: