IDAES / examples-pse

(ARCHIVED - use IDAES/examples) Example Python code, Jupyter Notebooks, and other files for the IDAES PSE
https://idaes.github.io/examples-pse/
Other
20 stars 36 forks source link

Adding Separation & Flash Unit Models into Jupyter Notebook #165

Closed MarcusHolly closed 1 year ago

MarcusHolly commented 1 year ago

Proposed changes:

Will add information for the following unit models into jupyter notebook

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
MarcusHolly commented 1 year ago

I'm not quite sure why this warning is appearing because I don't believe I am setting mole fraction bounds anywhere. image

andrewlee94 commented 1 year ago

@MarcusHolly You probably need to go through the Separator code to find out where that warning is being triggered - my guess is during creation of the outlets but that is just a guess.

Also, you can find icons for most unit operations here: https://github.com/IDAES/idaes-pse/tree/main/idaes/models/unit_models/icons which you should use in these examples. Notably, Separators are traditionally shown as a triangle, not a square.

MarcusHolly commented 1 year ago

@andrewlee94 So the issue is that the bounds are being defined in the property package (https://github.com/IDAES/idaes-pse/blob/main/idaes/models/properties/modular_properties/examples/CO2_H2O_Ideal_VLE.py) and then the FTPx modular properties file is just overwriting these bounds. Is there a simple way/line of code that can mute the bounds from being set in the first place so that this warning isn't displayed? image

andrewlee94 commented 1 year ago

The line setting the bounds on mole fractions should be removed from (https://github.com/IDAES/idaes-pse/blob/main/idaes/models/properties/modular_properties/examples/CO2_H2O_Ideal_VLE.py.

MarcusHolly commented 1 year ago

So should I open a new PR for this simple change in the IDAES repo? All of the other prop packs are fine (do not include mole_frac_comp in the state bounds).

andrewlee94 commented 1 year ago

@MarcusHolly Yes, please do (and do a quick check of the others whilst you are there).

MarcusHolly commented 1 year ago

Not sure how to go about resolving this one failure... the changes made in the last commit were very minimal and everything worked well before that.

andrewlee94 commented 1 year ago

@MarcusHolly Looks like the failure was a random one - rerunning the test fixed it.