search

IDAES / examples-pse

(ARCHIVED - use IDAES/examples) Example Python code, Jupyter Notebooks, and other files for the IDAES PSE
https://idaes.github.io/examples-pse/
Other
20 stars 36 forks source link

Fixing broken import and typos #167

Closed andrewlee94 closed 1 year ago

andrewlee94 commented 1 year ago

Fixes None.

Proposed changes:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
lbianchi-lbl commented 1 year ago

image

MarcusHolly commented 1 year ago

Seems like that file is very finicky for whatever reason. It has the same import error in my current PR (https://github.com/IDAES/examples-pse/pull/166)

andrewlee94 commented 1 year ago

@MarcusHolly No, it is because people we cleaned up "unused" imports in these files that were actually being used somewhere else. In short, the power plant developers were a bit lazy and wanted to import utility methods from their own modules rather than from the original location.

MarcusHolly commented 1 year ago

Ah, I see. Thanks for pointing that out.