search

IDAES / examples-pse

(ARCHIVED - use IDAES/examples) Example Python code, Jupyter Notebooks, and other files for the IDAES PSE
https://idaes.github.io/examples-pse/
Other
20 stars 36 forks source link

Update controller type arg name #175

Closed eslickj closed 1 year ago

eslickj commented 1 year ago

Fixes:

There was a change in the PID controller model that renamed an argument and broke a PETSc example. This is a fix for that. I'm not sure if I should fix it here. The same fix should be applied in the Example repo, but I couldn't find the example there. I think we should merge this so the notebook isn't broken here. @dangunter, if I need to do something to also change this in Examples, let me know what to do.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.