AlexNoring commented 2 months ago

NGFC Flowsheet Improvements

Updates to the NGFC flowsheet to fix initialization failure

Appropriate solver options are now being used for flowsheet initialization
Improved model scaling
Adjusted the initialization/solve sequence for the main flowsheet and the solver options for the final solve
Reformer and power island sections can be now be build separately for debugging

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--105.org.readthedocs.build/en/105/

JavalVyas2000 commented 2 months ago

@andrewlee94 should we move this example from archive to docs?

andrewlee94 commented 2 months ago

@JavalVyas2000 I believe it was on the list of examples Miguel suggested we make public so the answer is yes (assuming we can get it working reliably). I'll leave it up to you and @AlexNoring as to whether that should be done in this PR or not - note that if we do that we should add more diagnostics checks as well (assert_no_strucutral_issues and assert_no_numerical_issues) to make sure the flowsheet is well posed and robust.

AlexNoring commented 2 months ago

Let's leave moving this example to docs for a separate PR.

IDAES / examples

NGFC Flowsheet Improvements #105

NGFC Flowsheet Improvements