search

IDAES / examples

IDAES platform examples and tutorials
https://idaes-examples.readthedocs.io
Other
17 stars 36 forks source link

Liquid liquid extractor #91

Closed JavalVyas2000 closed 4 months ago

JavalVyas2000 commented 6 months ago

Liquid liquid extractor example

This PR is a comprehensive tutorial on how to create a unit model from scratch, including a property package and unit model. It also includes how to write the tests for both. This unit model also tackles two phases and has two inlet and outlet ports, thereby giving an example for the user to create a new unit model that has multiple phases with multiple ports for inlet and outlet.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--91.org.readthedocs.build/en/91/

agarciadiego commented 6 months ago

General comments:

bpaul4 commented 5 months ago

Hi @JavalVyas2000, I can review this PR today if it's ready. The branch is significantly behind main, is it safe to update the branch?

I'm curious why test_browse.py was deleted.

JavalVyas2000 commented 5 months ago

Hi @bpaul4, the branch is ready to be reviewed. The reason why test_browse.py was deleted becasue the CI has issues with PySimpleGUI and it was failing tests. I just wanted to make sure that the integration was fine and passed all the tests. I believe we can update the branch.

ksbeattie commented 4 months ago

@JavalVyas2000 any news here?