IDAES / idaes-ext

IDAES developer repo for those building the idaes binary solvers and related tools.
Other
8 stars 11 forks source link

Better support building without HSL #267

Closed Robbybp closed 5 months ago

Robbybp commented 6 months ago

Summary

https://github.com/IDAES/idaes-ext/pull/266 adds set -e, which causes builds to fail if HSL is not present. This PR fixes these failures, and adds an option to explicitly turn off building with HSL (even if it is available as a local zip file or elsewhere).

Changes

Admittedly, communicating arguments among various scripts is getting cumbersome. E.g. if you want to use --without-hsl in the docker build script, you need to pass arguments for the repo URL and branch, even if you just want to use default options. Maybe environment variables would be a better choice here, although I tend to prefer explicit command line arguments.