MEA PHE tests failing with Pyomo 6.7.0

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework

https://idaes-pse.readthedocs.io/

Other

210 stars 227 forks source link

MEA PHE tests failing with Pyomo 6.7.0 #1294

Open lbianchi-lbl opened 8 months ago

lbianchi-lbl commented 8 months ago

Observed on:

Windows (GHA)
Linux (by @andrewlee94 on his local machine)

FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_solve - AssertionError
FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_solution - AssertionError
FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_conservation - AssertionError

andrewlee94 commented 8 months ago

Initial symptoms suggest a scaling issue (platform dependent failures). Further investigations (using a local Linux build that fails) showed:

The associated change in Pyomo should only change variable ordering, which is observed.
However, inspecting the NL file also showed that the solution from the model initialization was significantly different, indicating that the source of the problem occurs during initialization.

dallan-keylogic commented 8 months ago

Unable to reproduce problem on my machine. @jsiirola suggested checking whether Pyomo presolve to remove trivial equality constraints might make this problem go away on its own.

lbianchi-lbl commented 7 months ago

No progress on this as of today.

dallan-keylogic commented 6 months ago

Need to try running this after the new Pyomo release when the presolve is added. Note that we might need to manually enable the presolve initially.