Closed andrewlee94 closed 3 months ago
Attention: Patch coverage is 53.23194%
with 123 lines
in your changes are missing coverage. Please review.
Project coverage is 77.52%. Comparing base (
3a1d54a
) to head (7997adf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@viiibhav @jghouse88 Not sure if either of you still receive these, but input and review on this PR would be welcome.
@viiibhav @jghouse88 Not sure if either of you still receive these, but input and review on this PR would be welcome.
Will take a look this week if that works. The best test would be to see if the paper examples work with this pr and see if we get similar results.
@jghouse88 I have tested this with the existing tests in IDAES, swapping the new formulation for the old one. All but two tests pass with the new formulation, but the two that fail appear to need further investigation - the temperature sweep test is failing to converge to the correct solution (it gets stuck somewhere).
Attention: Patch coverage is 83.45324%
with 46 lines
in your changes missing coverage. Please review.
Project coverage is 77.83%. Comparing base (
fff4546
) to head (c2a593d
). Report is 26 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Replaces #977
Summary/Motivation:
This PR adds an implementation of the improved Smooth VLE formulation originally proposed in #977. This implementation preserves the old implementation for backward compatibility.
Changes proposed in this PR:
SmoothVLE2
to implement improved formulationLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: