search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
206 stars 228 forks source link

Renaming components #1402

Closed andrewlee94 closed 1 month ago

andrewlee94 commented 2 months ago

Related to https://github.com/Pyomo/pyomo/pull/3221

Requires a fix in Pyomo and/or OMLT to address exception due to sub-classing metaclass. Will also require the Pyomo dependency to be updated.

Summary/Motivation:

This PR updates IDAES to use the new public names for Pyomo component data classes.

Changes proposed in this PR:

-

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 78.57143% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 77.88%. Comparing base (6fe724a) to head (d5ae666).

Files Patch % Lines
idaes/core/util/expr_doc.py 50.00% 3 Missing :warning:
idaes/core/util/model_diagnostics.py 78.57% 0 Missing and 3 partials :warning:
idaes/apps/caprese/common/config.py 33.33% 2 Missing :warning:
idaes/core/util/scaling.py 71.42% 0 Missing and 2 partials :warning:
idaes/apps/caprese/dynamic_block.py 75.00% 1 Missing :warning:
idaes/apps/caprese/util.py 75.00% 0 Missing and 1 partial :warning:
idaes/core/base/property_base.py 75.00% 0 Missing and 1 partial :warning:
idaes/core/base/var_like_expression.py 83.33% 1 Missing :warning:
idaes/core/util/tables.py 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1402 +/- ## ========================================== - Coverage 77.89% 77.88% -0.01% ========================================== Files 394 394 Lines 65061 65053 -8 Branches 14383 14383 ========================================== - Hits 50678 50667 -11 - Misses 11793 11797 +4 + Partials 2590 2589 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.