IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
206 stars 228 forks source link

[WIP] Remove the use of meta classes in the ProcessBlock class hierarchy #1404

Closed jsiirola closed 1 month ago

jsiirola commented 2 months ago

Fixes

Summary/Motivation:

The use of a metaclass for defining process blocks was both confusing and caused unintentional errors (conflicting metaclass definitions that faught with the RenamedClass backwards compatibility wrappers. This PR reworks the magic for declaring process block classes to:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
andrewlee94 commented 1 month ago

Closing this as low priority for now.