search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
206 stars 228 forks source link

Renewable + PEM Parameterized Bidder #1407

Open Xinhe-Chen opened 1 month ago

Xinhe-Chen commented 1 month ago

Fixes

Add the renewable+PEM parameterized bidder (bids the power at a constant price).

Summary/Motivation:

  1. Add a PerfectForecaster to predict the day-ahead and real-time wind power and electricity prices (if needed).
  2. Add a PEMParameterizedd bidder to bid the renewable power at a constant prices.

Changes proposed in this PR:

-

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
andrewlee94 commented 1 month ago

Also, we will need documentation for the new classes and how to use them.

Xinhe-Chen commented 1 month ago

Also, we will need documentation for the new classes and how to use them.

Thank you for your comments! I am still working on improving the tests. The documentation will be added in this PR https://github.com/IDAES/idaes-pse/pull/1090.

Xinhe-Chen commented 1 month ago

@radhakrishnatg Hi Radhakrishna, would you please review this PR? Thank you!

Xinhe-Chen commented 1 month ago

@adowling2 this is ready for review.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.64780% with 26 lines in your changes missing coverage. Please review.

Project coverage is 76.37%. Comparing base (10b42e4) to head (31f6e46).

Files Patch % Lines
idaes/apps/grid_integration/bidder.py 87.30% 15 Missing and 1 partial :warning:
idaes/apps/grid_integration/forecaster.py 69.69% 8 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1407 +/- ## ========================================== + Coverage 76.36% 76.37% +0.01% ========================================== Files 394 394 Lines 64953 65108 +155 Branches 14404 14423 +19 ========================================== + Hits 49601 49727 +126 - Misses 12793 12820 +27 - Partials 2559 2561 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ksbeattie commented 3 weeks ago

@Xinhe-Chen any news on this?

Xinhe-Chen commented 3 weeks ago

@Xinhe-Chen any news on this?

I will request a review from Prof. Dowling again.

adowling2 commented 3 weeks ago

Tag other people too

Xinhe-Chen commented 2 weeks ago

@dguittet Hi Darice, I created this PR to merge the renewable-parameterized bidder code in dispatches into IDAES, would you mind reviewing it? Thank you!

Xinhe-Chen commented 1 week ago

@adowling2 This is ready for review.

Xinhe-Chen commented 1 week ago

@ksbeattie Hi Keith, we hope to have this PR reviewed and merged next week.

Xinhe-Chen commented 3 days ago

@Xinhe-Chen, please reply to the open comments to confirm these were addressed.

Hi Prof. Dowling, I addressed all comments from you last Friday.

I am going to to a final check later today to ensure no other issues are remaining later today.

adowling2 commented 3 days ago

Excellent. Tag me here when it is ready to review.

Xinhe-Chen commented 3 days ago

Excellent. Tag me here when it is ready to review.

@adowling2 This is ready for review.