search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
216 stars 232 forks source link

Infeasibility diagnostic tool #1409

Closed bknueven closed 4 months ago

bknueven commented 4 months ago

Fixes #1405

Summary/Motivation:

See discussion on #1405

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
bknueven commented 4 months ago

The spell checker is hitting false positives on "mis" and "MIS".

andrewlee94 commented 4 months ago

@bknueven You can add exclusions for the spell checker here: https://github.com/IDAES/idaes-pse/blob/main/.github/workflows/typos.toml

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.88%. Comparing base (5d2f94c) to head (40670e4).

Files Patch % Lines
idaes/core/util/model_diagnostics.py 81.25% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1409 +/- ## ========================================== - Coverage 77.89% 77.88% -0.01% ========================================== Files 394 394 Lines 65053 65069 +16 Branches 14383 14385 +2 ========================================== + Hits 50670 50680 +10 - Misses 11793 11798 +5 - Partials 2590 2591 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.