search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
216 stars 232 forks source link

Adding USD_2022 to units library as the most recently published value #1413

Closed hunterbarber closed 4 months ago

hunterbarber commented 4 months ago

Fixes

Append USD_YYYY list with USD_2022 value from https://toweringskills.com/financial-analysis/cost-indices/

Summary/Motivation:

Add more up to date values for USD

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
hunterbarber commented 4 months ago

Note the conversion value for USD_2021 in the repo differs from the one published in https://toweringskills.com/financial-analysis/cost-indices/ (708.0 compared to 708.8). I imagine changing this value in the repo would require a lot of downstream changes in value assertions for costing tests, so I'm leaving as is.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.89%. Comparing base (f0c60c4) to head (b69e53c). Report is 18 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1413 +/- ## ========================================== - Coverage 77.89% 77.89% -0.01% ========================================== Files 394 394 Lines 65079 65079 Branches 14389 14389 ========================================== - Hits 50695 50692 -3 - Misses 11795 11799 +4 + Partials 2589 2588 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewlee94 commented 4 months ago

@hunterbarber @bpaul4 We need to be careful about changing values like this; whilst we might not test against it, others might be using the values and this would be an unexpected change for them. If there is good cause for the change then we can consider it, but we would also need to discuss backward compatibility.