Closed andrewlee94 closed 3 months ago
@Daison2102 @AlexNoring If you have some time, it would be appreciated if you could look into why the TSA initialization fails with the presolver. It appears that one of the steps results in an invalid value that causes an exception in AMPL (at first guess, I suspect a value is being fixed to a singular point).
For now, I have set the TSA initializer to not use the presolver.
@Daison2102 @AlexNoring If you have some time, it would be appreciated if you could look into why the TSA initialization fails with the presolver. It appears that one of the steps results in an invalid value that causes an exception in AMPL (at first guess, I suspect a value is being fixed to a singular point).
For now, I have set the TSA initializer to not use the presolver.
@andrewlee94 The TSA tests pass for me when I set heating_time_guess
to 400 for the TestTsaPolystyrene
class.
Attention: Patch coverage is 37.61468%
with 68 lines
in your changes missing coverage. Please review.
Project coverage is 77.68%. Comparing base (
2ac6417
) to head (f39ccdf
). Report is 27 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing in favour of #1436. This PR tried to do too much at once and ran into backward compatibility issues.
Fixes None
Summary/Motivation:
This PR builds on previous work to bring the new Pyomo solver interfaces into IDAES and activates the use of the new linear presolver.
All core code (
core
andmodels
) has been updated to use the presolver, however many parts ofmodels_extra
have issues relating to the pre-solver.Power Generation:
Changes proposed in this PR:
-
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: