Closed andrewlee94 closed 4 months ago
Attention: Patch coverage is 93.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 77.89%. Comparing base (
3cf3a84
) to head (f8b2b95
). Report is 24 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
idaes/core/util/model_diagnostics.py | 93.33% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why add this feature instead of relaxing the tests for these older models? I suppose the reason is that we still want to test that these have no extreme Jacobian entries, and condition numbers in some range. Is there no way to extract just the numerical warnings that we actually want to enforce (as we might do with check_parallel_jacobian
if we just wanted to check for parallel rows/columns).
@Robbybp Mostly as a placeholder until we get the new scaling tools in place and have the time to go and address each of these.
We also have a case where someone is working on updating some of the power plant examples for us, and I asked them to add checks for structural and numerical issues, but they lack the time or background to try to fix these for now. Thus, I added this so they can skip these tests for now and get their PR merged without waiting until the power plant team can address the issues.
Fixes None
Summary/Motivation:
This adds an option to skip checks for parallel constraints and variables, primarily for use in testing where we have cases of known near-parallel components. This is mostly for backward compatibility with older models which we do not currently have time to fix.
Changes proposed in this PR:
-
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: