Fix some bugs in the modular properties implementation - Githubissues

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework

https://idaes-pse.readthedocs.io/

Other

206 stars 228 forks source link

Fix some bugs in the modular properties implementation #1425

Closed andrewlee94 closed 1 month ago

andrewlee94 commented 1 month ago

Fixes #1423, #1424

Summary/Motivation:

Two issues were recently raised identifying bugs in the modular properties code.

Changes proposed in this PR:

Correct how phase_equilibrium_list is created in generic_properties.py so that is a list (as expected) and not a dict.
Add catch in FTPx state initialization to handle cases with non-VLE phase equilibrium
Add regression checks for the above issues.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

bpaul4 commented 1 month ago

LGTM, I manually retriggered the coverage upload tests which should remove the block.