search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
216 stars 232 forks source link

Sofc Keras Surrogates failing tests #1431

Closed rundxdi closed 1 month ago

rundxdi commented 3 months ago

Tests on sofc_keras_surrogate.py are failing due to an out-of-date Keras model that needs to be re-generated by someone who knows about the model. A deprecation warning indicating these failures has been added.

ksbeattie commented 3 months ago

Discovered in #1401

ksbeattie commented 3 months ago

This will need to wait for #1401 to be merged before re-generating the model (and other keras related ones).

lbianchi-lbl commented 2 months ago

This should be done independently of #1401 so that #1401 is not held up. A separate PR after #1401 is merged should be created once @AlexNoring recreates the model using the updated (post-#1401) supported version of Keras/Tensorflow.

AlexNoring commented 1 month ago

The SOFC flowsheets in the examples repository no longer use the keras surrogates. I'd suggest we simply remove the files.

ksbeattie commented 1 month ago

@bpaul4 will open a PR addressing this.