IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
206 stars 228 forks source link

Activating IPOPT_V2 with presolver #1436

Closed andrewlee94 closed 1 week ago

andrewlee94 commented 2 weeks ago

Replaces #1415

Summary/Motivation:

Second attempt at implementing new solver interface with presolve. Due to the need to maintain backward compatibility, the old model.initialize() methods will continue to use the old ipopt solver interface, whilst the new Initializers and core tests will switch to ipopt_v2. The default solver will remain ipopt for now until all the examples have been switched over (or updated to explicitly use ipopt), at which point we will deprecate the use of ipopt as the default.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.73%. Comparing base (a66d4c4) to head (2df54c5).

Files Patch % Lines
...erties/modular_properties/base/generic_property.py 57.89% 4 Missing and 4 partials :warning:
idaes/core/solvers/config.py 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1436 +/- ## ========================================== - Coverage 77.83% 77.73% -0.10% ========================================== Files 394 394 Lines 64926 64953 +27 Branches 14398 14404 +6 ========================================== - Hits 50535 50494 -41 - Misses 11807 11879 +72 + Partials 2584 2580 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.