Closed andrewlee94 closed 1 week ago
Attention: Patch coverage is 85.71429%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 77.73%. Comparing base (
a66d4c4
) to head (2df54c5
).
Files | Patch % | Lines |
---|---|---|
...erties/modular_properties/base/generic_property.py | 57.89% | 4 Missing and 4 partials :warning: |
idaes/core/solvers/config.py | 33.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Replaces #1415
Summary/Motivation:
Second attempt at implementing new solver interface with presolve. Due to the need to maintain backward compatibility, the old
model.initialize()
methods will continue to use the oldipopt
solver interface, whilst the newInitializers
and core tests will switch toipopt_v2
. The default solver will remainipopt
for now until all the examples have been switched over (or updated to explicitly useipopt
), at which point we will deprecate the use ofipopt
as the default.Changes proposed in this PR:
writer_config
argument and deprecatingoptions
forsolver_options
).Initializers
to useipopt_v2
.idaes/core
andidaes/models
tests to useipopt_v2
.Where possible, switchidaes/apps
andidaes/models_extra
tests to useipopt_v2
.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: