search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Limiting pint version #1438

Closed andrewlee94 closed 5 months ago

andrewlee94 commented 5 months ago

Fixes None

Summary/Motivation:

Pint recently released v0.24 which changed some behavior in how dimensionless quantities are displayed and thus causes tests to start failing. However, v0.24 is only supported on Python 3.10 and greater, and thus we cannot switch tho the new version as we still support older version of Python.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.79%. Comparing base (2ac6417) to head (4cf9b11). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1438 +/- ## ========================================== - Coverage 77.80% 77.79% -0.01% ========================================== Files 393 393 Lines 64797 64797 Branches 14390 14390 ========================================== - Hits 50413 50410 -3 - Misses 11794 11798 +4 + Partials 2590 2589 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.