Open dallan-keylogic opened 3 months ago
This looks really useful, thanks for making the change. I'll give it a review soon.
Attention: Patch coverage is 80.88235%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 76.36%. Comparing base (
10b42e4
) to head (6850cb2
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
idaes/core/solvers/petsc.py | 80.88% | 7 Missing and 6 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Robbybp, just a friendly nag to review when (or if) you have some time.
@Robbybp , could you please review this sometime soon? I'd really like it to make the August release.
Progress not expected until end of Sept (per @dallan-keylogic)
Fixes
None
Summary/Motivation:
When using the PETSc interface, a square initial condition problem is first solved (with either PETSc-snes or IPOPT) to make sure the initial condition is consistent before sending integrations problems to PETSc-TS. However, when you end up with degree of freedom problems or a degenerate problem, it's difficult to debug. As an expedient, I would edit the PETSc problem to return the problem in the middle of the context manager.
I've added a function to get this problem directly and modified the PETSc interface to use this function to get the initial condition problem to solve to ensure consistency.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: