IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
217 stars 235 forks source link

PriceTaker Model Checklist #1449

Open adam-a-a opened 4 months ago

adam-a-a commented 4 months ago

The PriceTaker class must still be merged into the main codebase. This class and associated workflow can be useful for projects related to DISPATCHES-type work. For example, modeling flexible desalination in WaterTAP is of interest, and we could make use of the Pricetaker class.

Here is a to-do list based on @andrewlee94 's suggested changes and @radhakrishnatg 's suggestions for enhancement.

Finish PR #1358

Create new PR(s) for the following

ksbeattie commented 4 months ago

@adam-a-a, @MarcusHolly, @radhakrishnatg will you be opening PRs here in idaes-pse for this? If so, might one of you be able to join the dev call to discuss and track progress? If not any of you, then who?

adam-a-a commented 4 months ago

@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.

As for new PRs, we would open these here on idaes-PSE, only after merging said PR.

MarcusHolly commented 4 months ago

@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.

As for new PRs, we would open these here on idaes-PSE, only after merging said PR.

I just joined the call and gave a brief update, more or less saying what you've stated here. I can join the calls in the future.

ksbeattie commented 2 months ago

Moving this to the Nov release board.