search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Use `el8` binaries when we encounter RHEL9 #1457

Closed Robbybp closed 3 months ago

Robbybp commented 4 months ago

Fixes #1456

Hopefully. I don't have RHEL9 or Rocky9, so I haven't tested.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.35%. Comparing base (80d37a8) to head (dd20dd3). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1457 +/- ## ========================================== - Coverage 76.36% 76.35% -0.01% ========================================== Files 394 394 Lines 64953 64953 Branches 14404 14404 ========================================== - Hits 49601 49598 -3 - Misses 12793 12797 +4 + Partials 2559 2558 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

lbianchi-lbl commented 4 months ago

@eslickj just pinging you in case you can think of any reason why this change could have unexpected consequences; to me, without knowing the details, it looks reasonable.

mrmundt commented 3 months ago

This PR is going to be superseded by https://github.com/IDAES/idaes-ext/issues/274 <- completion of that will mean we have a RHEL9 binary anyway, so this temporary remapping will be irrelevant.

ksbeattie commented 3 months ago

Closed in preference to https://github.com/IDAES/idaes-ext/issues/274