Closed lbianchi-lbl closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.37%. Comparing base (
04fa887
) to head (4696841
). Report is 27 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just one non-critical comment.
There is one mention on Python 3.8 on the FAQ page: https://github.com/IDAES/idaes-pse/blob/main/docs/explanations/faq.rst. The
pywin32
issue may be relevant to other Python version, in which case we could leave the FAQ as-is.
Good point, I did notice this as well and opted for leaving it in for the same reason you mentioned. I propose to leave that in unless someone objects.
@lbianchi-lbl @bpaul4 I suggest we keep the discussion as well, but add a note to indicate that Python 3.8 is no longer officially supported (i.e. make it clear we left this comment there for those who wish to try (or have similar issues), but that we don't guarantee that the rest of the code will work).
@lbianchi-lbl @bpaul4 I suggest we keep the discussion as well, but add a note to indicate that Python 3.8 is no longer officially supported (i.e. make it clear we left this comment there for those who wish to try (or have similar issues), but that we don't guarantee that the rest of the code will work).
@andrewlee94 I've added a note there (and the same to README.md
for good measure):
Resolves #1462
Changes proposed in this PR:
setup.py
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: