IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Remove support for Python 3.8 #1467

Closed lbianchi-lbl closed 3 months ago

lbianchi-lbl commented 3 months ago

Resolves #1462

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.37%. Comparing base (04fa887) to head (4696841). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1467 +/- ## ========================================== - Coverage 76.38% 76.37% -0.01% ========================================== Files 394 394 Lines 65108 65108 Branches 14423 14423 ========================================== - Hits 49732 49729 -3 - Misses 12814 12818 +4 + Partials 2562 2561 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lbianchi-lbl commented 3 months ago

Just one non-critical comment.

There is one mention on Python 3.8 on the FAQ page: https://github.com/IDAES/idaes-pse/blob/main/docs/explanations/faq.rst. The pywin32 issue may be relevant to other Python version, in which case we could leave the FAQ as-is.

Good point, I did notice this as well and opted for leaving it in for the same reason you mentioned. I propose to leave that in unless someone objects.

andrewlee94 commented 3 months ago

@lbianchi-lbl @bpaul4 I suggest we keep the discussion as well, but add a note to indicate that Python 3.8 is no longer officially supported (i.e. make it clear we left this comment there for those who wish to try (or have similar issues), but that we don't guarantee that the rest of the code will work).

lbianchi-lbl commented 3 months ago

@lbianchi-lbl @bpaul4 I suggest we keep the discussion as well, but add a note to indicate that Python 3.8 is no longer officially supported (i.e. make it clear we left this comment there for those who wish to try (or have similar issues), but that we don't guarantee that the rest of the code will work).

@andrewlee94 I've added a note there (and the same to README.md for good measure):

image