IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Property naming conventions for vapor pressure and saturation vapor pressure #1481

Closed kurbansitterley closed 2 months ago

kurbansitterley commented 2 months ago

I have relative_humidity = vapor_pressure / saturated_vapor_pressure.

According to the IDAES docs page on IDAES property naming conventions, vapor_pressure should be pressure_sat, which I am not sure I understand (since vapor_pressure would not be saturated unless relative humidity is 100%... or maybe I am missing something). But then does that mean saturated_vapor_pressure should be pressure_sat_equil? In this case, vapor_pressure is the partial pressure of water under given conditions and saturated_vapor_pressure is the vapor pressure of water in equilibrium with an open liquid surface.

I suppose the issue here is:

Or maybe there is a different way to do it that would adhere to the conventions as they are already laid out?

(This may be better suited as a discussion rather than an issue so I am happy to move it if so)

andrewlee94 commented 2 months ago

@kurbansitterley I think the source of your confusion is that you are thinking of a fairly specific use case where as the IDAES names are general (i.e. they have no concept of a liquid surface, boundary layer or anything like that). Note that "vapor pressure" is somewhat ambiguous (hence the IDAES names), as there are different states at which you might want the partial pressure of a component. Thus, we went with somewhat more technical, but hopefully more specific naming.

Hopefully that clears things up a bit.

R.e. conc_phase_comp is not a valid name, and should be comp_BASIS_phase_comp - if you can point us to where it says that (or correct it yourself) it would be appreciated.

andrewlee94 commented 2 months ago

And an after thought - the above assumes only a vapor phase is present. If you have a multiphase system then you would want pressure_phase_comp and pressure_sat_phase_comp.

kurbansitterley commented 2 months ago

@andrewlee94 I appreciate the response and had not thought of pressure_comp["H2O"]. I agree this a specific use case and I went down the rabbit hold of wanting to conform to conventions.

I have opened #1482 to address the conc_phase_comp question. And now that I am looking at it - does flow_comp["H2O"] not also require a basis?

andrewlee94 commented 2 months ago

Yes, it should be flow_BASIS_comp.