search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Fix nested flowsheet time domain construction #1495

Open NishantGiridhar opened 1 month ago

NishantGiridhar commented 1 month ago

Fixes

Summary/Motivation:

In the current implementation of FlowsheetBlock, nested flowsheets with a time domain can only inherit time from the parent flowsheet.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
dangunter commented 1 month ago

@NishantGiridhar any update on this?

andrewlee94 commented 1 month ago

@NishantGiridhar You need to run black on the changes to get the tests to pass.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.05%. Comparing base (c4336ba) to head (aae6730).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1495 +/- ## ========================================== - Coverage 77.05% 77.05% -0.01% ========================================== Files 384 384 Lines 62335 62341 +6 Branches 10222 10224 +2 ========================================== + Hits 48031 48034 +3 - Misses 11875 11879 +4 + Partials 2429 2428 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: