search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Fix issue with enthalpy based states trying to use EoS before construciton #1505

Closed andrewlee94 closed 1 month ago

andrewlee94 commented 1 month ago

Fixes #1483

Summary/Motivation:

Issue #1483 identified that enthalpy-based state definitions in the modular property framework triggered calls to components constructed by the equation of state module before these had been instantiated. This PR defers the construction of the constraint relating total molar enthalpy to the phase molar enthalpies until after the EoS components have been instantiated.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.98%. Comparing base (0e05ed1) to head (be76ce4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1505 +/- ## ========================================== - Coverage 76.98% 76.98% -0.01% ========================================== Files 382 382 Lines 61913 61911 -2 Branches 10130 10126 -4 ========================================== - Hits 47665 47660 -5 - Misses 11848 11852 +4 + Partials 2400 2399 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.