IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
218 stars 235 forks source link

Minor improvements to scaling API #1507

Closed andrewlee94 closed 1 month ago

andrewlee94 commented 1 month ago

Fixes None

Summary/Motivation:

Based on initial demonstrations of the new scaling tools, a few minor improvements have been suggested.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.98%. Comparing base (96237b9) to head (e45968b). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
idaes/core/scaling/custom_scaler_base.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1507 +/- ## ========================================== - Coverage 76.99% 76.98% -0.01% ========================================== Files 382 382 Lines 61993 61992 -1 Branches 10146 10146 ========================================== - Hits 47733 47727 -6 - Misses 11852 11858 +6 + Partials 2408 2407 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.