search

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework
https://idaes-pse.readthedocs.io/
Other
216 stars 234 forks source link

"pylint -E" discoveries in ui module #47

Closed ksbeattie closed 3 years ago

ksbeattie commented 4 years ago

If one runs pylint -E ui (after running pip install pylint) you get to see all kinds of fun problems that should probably be fixed or at least looked into. Below is what I'm currently seeing.

************* Module modelvis.hda_reaction
ui/modelvis/hda_reaction.py:56:36: E0602: Undefined variable 'HDAReactionBlock' (undefined-variable)
ui/modelvis/hda_reaction.py:112:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_reaction.py:148:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_reaction.py:149:15: E1101: Instance of 'molar' has no 'molar' member (no-member)
************* Module modelvis.hda_ideal_VLE
ui/modelvis/hda_ideal_VLE.py:56:33: E0602: Undefined variable 'IdealStateBlock' (undefined-variable)
ui/modelvis/hda_ideal_VLE.py:341:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:512:23: E1101: Instance of 'unknown' has no 'optimal' member (no-member)
ui/modelvis/hda_ideal_VLE.py:530:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:623:31: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/hda_ideal_VLE.py:625:38: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/hda_ideal_VLE.py:802:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:803:15: E1101: Instance of 'molar' has no 'molar' member (no-member)
ui/modelvis/hda_ideal_VLE.py:839:15: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/hda_ideal_VLE.py:877:15: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/hda_ideal_VLE.py:962:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:994:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:1007:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:1025:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:1057:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/hda_ideal_VLE.py:1070:4: E0213: Method should have "self" as first argument (no-self-argument)
************* Module modelvis.flowsheetvisdemo.hda_reaction
ui/modelvis/flowsheetvisdemo/hda_reaction.py:56:36: E0602: Undefined variable 'HDAReactionBlock' (undefined-variable)
ui/modelvis/flowsheetvisdemo/hda_reaction.py:112:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_reaction.py:148:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_reaction.py:149:15: E1101: Instance of 'molar' has no 'molar' member (no-member)
************* Module modelvis.flowsheetvisdemo.hda_ideal_VLE
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:56:33: E0602: Undefined variable 'IdealStateBlock' (undefined-variable)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:341:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:512:23: E1101: Instance of 'unknown' has no 'optimal' member (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:530:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:623:31: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:625:38: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:802:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:803:15: E1101: Instance of 'molar' has no 'molar' member (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:839:15: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:877:15: E1101: Instance of 'Var' has no 'value' member; maybe 'values'? (no-member)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:962:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:994:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:1007:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:1025:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:1057:4: E0213: Method should have "self" as first argument (no-self-argument)
ui/modelvis/flowsheetvisdemo/hda_ideal_VLE.py:1070:4: E0213: Method should have "self" as first argument (no-self-argument)
perrenyang commented 4 years ago

Oh hm, I think this is one of the copied property packages. This seems like it'd be resolved when we do something about importing them properly (or... removing them and the demo?)

ksbeattie commented 4 years ago

@perrenyang could you reference (or perhaps open) and issue to address importing/copying them properly?

lbianchi-lbl commented 3 years ago

The pylint campaign is still ongoing, but all the error categories represented in this particular set/module are fixed by #58, so this can be closed.