Update uncertainty propagation toolbox to use sens.py in Pyomo

IDAES / idaes-pse

The IDAES Process Systems Engineering Framework

https://idaes-pse.readthedocs.io/

Other

210 stars 227 forks source link

Open jialuw96 opened 2 years ago

jialuw96 commented 2 years ago

Challenge / problem:

sens.py was copied from Pyomo, and duplicated in IDAES uncertainty toolbox to get it work
sens.py has since been updated in Pyomo to improve code clarity and style
Two separate versions of sens.py is confusing

Proposal: remove sens.py in IDAES, update uncertainty toolbox to use sens.py in Pyomo

Tasks:

[ ] get_dsdp() in Pyomo sens.py assumes the Pyomo model has already been solved, whereas the version in IDAES solves the model

ksbeattie commented 2 years ago

@jialuw96, is this something you will do?

ksbeattie commented 2 years ago

@adowling2 & @jialuw96, I'm pulling this off the release boards and adding the backlog label, in hopes that someone may eventually get to this.

adowling2 commented 2 years ago

Sounds good. Looks like we'll need this for a milestone next project year so it will get done.