search

IDAES / idaes-ui

User interfaces for IDAES
Other
1 stars 5 forks source link

Issue 45 send back diagram image #51

Open CopyDemon opened 2 months ago

CopyDemon commented 2 months ago

Fixes Related to issue Project board link

Proposed changes: User can get and view diagram screenshot in Jupyter notebook

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
dangunter commented 1 month ago

@lbianchi-lbl suggested a simpler way to approach all this, which I think makes sense. Use standard HTML5 browser APIs to convert the SVG element to a PNG in Javascript. Then the Playwright/Selenium etc. is not required

ksbeattie commented 3 weeks ago

@CopyDemon what's the news here?

CopyDemon commented 2 weeks ago

@CopyDemon what's the news here?

I'm back working on this issue now. It seems like screenshots are not being saved on Windows. I'm trying to find a Windows computer to test it and determine whether the issue is with pytest or if it's just not saving on Windows.

CopyDemon commented 3 days ago

@dangunter when you have time please help me to review this.