IDEA-Research / DAB-DETR

[ICLR 2022] Official implementation of the paper "DAB-DETR: Dynamic Anchor Boxes are Better Queries for DETR"
Apache License 2.0
501 stars 86 forks source link

Use of query_embed.weight in segmentation.py #77

Closed conditionedstimulus closed 2 months ago

conditionedstimulus commented 3 months ago

Hi, team!

In the segmentation.py file on line 59: hs, memory = self.detr.transformer(src_proj, mask, self.detr.query_embed.weight, pos[-1]) you refer to self.detr.query_embed.weight, but in transformer.py on line 123, this embedding layer is commented out. I'd like to understand the reason behind this and whether this is still valid for segmentation cases.

Thanks!

conditionedstimulus commented 2 months ago

Answered in https://github.com/IDEA-Research/DAB-DETR/issues/28