IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 103 forks source link

Custom Controls Enhancements #5215

Open Patowhiz opened 5 years ago

Patowhiz commented 5 years ago

Is your feature request related to a problem? Please describe. Currently our controls lack methods that ease how dialogs and other controls can interact with them while at the same time promoting the principles of Object Oriented Programming. For instance there is no clear easy way of getting currently selected dataframe from the selector and we have to access it through its internal controls (e.g ucrSelector.ucrAvailableDataFrames.cboAvailableDataFrames.Text), we can't set the basic things like the colour of our ucrTextInput without accessing the internal textbox. etc

@dannyparsons in addition we also don't have a general method of getting and setting the value of our custom controls. For instance like for ucrInput we have GetText(),GetValue() and SetName(). I suggest a better suggestive method like SetValue(), GetValue() to be inherited and implemented by all the controls that need to override the default implementation. Same applies to other methods like for validations.

Describe the solution you'd like Adding these methods to the custom controls

dannyparsons commented 5 years ago

Can you be more specific and list the places where we currently don't have methods? Then we can know what there is to do.

Patowhiz commented 5 years ago

I'll have the specifics added as I improve and add the methods in the PR.